Expose the PAGLayer::setAlpha() method as a public API for iOS and Android.#2783
Merged
Expose the PAGLayer::setAlpha() method as a public API for iOS and Android.#2783
Conversation
domchen
reviewed
Apr 18, 2025
| * Set the alpha of the layer, which will be concatenated to the current animation opacity for | ||
| * displaying. | ||
| */ | ||
| public native void setAlpha(float value); |
Collaborator
There was a problem hiding this comment.
这个属性读写要成对，把alpha读取属性也要暴露出来。
leiyue123
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2783 +/- ##
==========================================
- Coverage 77.41% 77.40% -0.01%
==========================================
Files 419 419
Lines 22270 22270
Branches 6366 6290 -76
==========================================
- Hits 17240 17238 -2
Misses 3775 3775
- Partials 1255 1257 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
domchen
reviewed
Apr 18, 2025
| /** | ||
| * Returns the current alpha of the layer if previously set. | ||
| */ | ||
| public native float alpha(); |
Collaborator
There was a problem hiding this comment.
按照项目习惯，get放法一般都写在set之前。调整一下顺序。
leiyue123
changed the title
domchen
changed the title
domchen
reviewed
Apr 18, 2025
Comment on lines
+176
to
+177
| * Returns the current alpha of the layer if previously set. | ||
| */ |
Collaborator
There was a problem hiding this comment.
注释缩进不对，Java代码没法被工具自动格式化，自己要注意格式化问题。
domchen
approved these changes
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
将layer层cpp接口setAlpha、alpha暴露到ios和android